linux-kernel - Re: [PATCH 00/12] Stitch LBR call stack (Perf Tools)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Mar 2020 09:42:06 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, peterz@...radead.org,
        mingo@...hat.com, linux-kernel@...r.kernel.org,
        namhyung@...nel.org, adrian.hunter@...el.com,
        mathieu.poirier@...aro.org, ravi.bangoria@...ux.ibm.com,
        alexey.budankov@...ux.intel.com, vitaly.slobodskoy@...el.com,
        pavel.gerasimov@...el.com, mpe@...erman.id.au, eranian@...gle.com,
        ak@...ux.intel.com
Subject: Re: [PATCH 00/12] Stitch LBR call stack (Perf Tools)



On 3/9/2020 9:27 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 06, 2020 at 02:13:15PM -0500, Liang, Kan escreveu:
>>
>>
>> On 3/6/2020 4:39 AM, Jiri Olsa wrote:
>>> On Fri, Feb 28, 2020 at 08:29:59AM -0800, kan.liang@...ux.intel.com wrote:
>>>
>>> SNIP
>>>
>>>> Kan Liang (12):
>>>>     perf tools: Add hw_idx in struct branch_stack
>>>>     perf tools: Support PERF_SAMPLE_BRANCH_HW_INDEX
>>>>     perf header: Add check for event attr
>>>>     perf pmu: Add support for PMU capabilities
>>>
>>> hi,
>>> I'm getting compile error:
>>>
>>> 	util/pmu.c: In function ‘perf_pmu__caps_parse’:
>>> 	util/pmu.c:1620:32: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 0 and 4095 [-Werror=format-truncation=]
>>> 	 1620 |   snprintf(path, PATH_MAX, "%s/%s", caps_path, name);
>>> 	      |                                ^~
>>> 	In file included from /usr/include/stdio.h:867,
>>> 			 from util/pmu.c:12:
>>> 	/usr/include/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 2 and 4352 bytes into a destination of size 4096
>>> 	   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
>>> 	      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> 	   68 |        __bos (__s), __fmt, __va_arg_pack ());
>>> 	      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> 	cc1: all warnings being treated as errors
>>>
>>> 	[jolsa@...va perf]$ gcc --version
>>> 	gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1)
>>
>> My GCC version is too old. I will send V2 later to fix the error.
> 
> So I stopped at the patch just before the one introducing this problem,
> i.e. now I have:
> 
> [acme@...enth perf]$ git log --oneline -10
> 5100c2b77049 (HEAD -> perf/core, five/perf/core, acme/perf/core) perf header: Add check for unexpected use of reserved membrs in event attr
> 1d2fc2bd7c1c perf evsel: Support PERF_SAMPLE_BRANCH_HW_INDEX
> 1fa65c5092da perf tools: Add hw_idx in struct branch_stack
> 6339998d22ec tools headers UAPI: Update tools's copy of linux/perf_event.h
> 401d61cbd4d4 tools lib traceevent: Remove extra '\n' in print_event_time()
> 76ce02651dab libperf: Add counting example
> dabce16bd292 perf annotate: Get rid of annotation->nr_jumps
> 357a5d24c471 perf llvm: Add debug hint message about missing kernel-devel package
> 1af62ce61cd8 perf stat: Show percore counts in per CPU output
> 7982a8985150 tools lib api fs: Move cgroupsfs_find_mountpoint()
> [acme@...enth perf]$
> 
> Please continue from there, I'll process some other patchsets,
> 

Sure. I will re-base my patchset on top of it.

Thanks,
Kan