linux-kernel - Re: [PATCH] nvmem: jz4780-efuse: fix build warnings on ARCH=x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e444754a-3bd3-d46f-d2f9-188fb2cc6f0e@linaro.org>
Date:   Mon, 9 Mar 2020 13:52:49 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>,
        PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>
Cc:     linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        letux-kernel@...nphoenux.org, kbuild test robot <lkp@...el.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>, malat@...ian.org,
        paul@...pouillou.net
Subject: Re: [PATCH] nvmem: jz4780-efuse: fix build warnings on ARCH=x86_64 or
 riscv



On 06/03/2020 19:17, H. Nikolaus Schaller wrote:
> kbuild-robot did find a type error in the min(a, b)
> function used by this driver if built for x86_64 or riscv.
> 
> Althought it is very unlikely that this driver is built
> for those platforms it could be used as a template
> for something else and therefore should be correct.
> 
> The problem is that we implicitly cast a size_t to
> unsigned int inside the implementation of the min() function.
> 
> Since size_t may differ on different compilers and
> plaforms there may be warnings or not.
> 
> So let's use only size_t variables on all platforms.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: srinivas.kandagatla@...aro.org
> Cc: prasannatsmkumar@...il.com
> Cc: malat@...ian.org
> Cc: paul@...pouillou.net
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>   drivers/nvmem/jz4780-efuse.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied thanks,
srini