linux-kernel - Re: [PATCH 2/6] dt-bindings: Add Baikal-T1 APB-bus EHB dts bindings file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Mar 2020 13:07:43 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sergey.Semin@...kalelectronics.ru
Cc:     Mark Rutland <mark.rutland@....com>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        soc@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: Add Baikal-T1 APB-bus EHB dts bindings
 file

On Fri, 6 Mar 2020 16:07:17 +0300, <Sergey.Semin@...kalelectronics.ru> wrote:
> From: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> 
> This is a specific block embedded into the Baikal-T1 SoC, which is
> dedicated to detect APB-bus protocol errors and tune the peripheral
> access timeout. So the dts bindings implies that corresponding dts
> node would be equipped with "be,bt1-apb-ehb" compatible string, MMIO
> region of registers space and of space with no device mapped,
> interrupts property and with an APB-reference clock handler.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: Paul Burton <paulburton@...nel.org>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Olof Johansson <olof@...om.net>
> Cc: soc@...nel.org
> ---
>  .../soc/baikal-t1/be,bt1-apb-ehb.yaml         | 66 +++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/baikal-t1/be,bt1-apb-ehb.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/soc/baikal-t1/be,bt1-apb-ehb.example.dts:18:18: fatal error: dt-bindings/clock/bt1-ccu.h: No such file or directory
         #include <dt-bindings/clock/bt1-ccu.h>
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/soc/baikal-t1/be,bt1-apb-ehb.example.dt.yaml' failed
make[1]: *** [Documentation/devicetree/bindings/soc/baikal-t1/be,bt1-apb-ehb.example.dt.yaml] Error 1
Makefile:1262: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1250282
Please check and re-submit.