linux-kernel - Re: [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83af52172a3cabd662de1ed9574e4247@walle.cc>
Date:   Mon, 09 Mar 2020 20:06:30 +0100
From:   Michael Walle <michael@...le.cc>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     broonie@...nel.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, shawnguo@...nel.org,
        robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, eha@...f.com, angelo@...am.it,
        andrew.smirnov@...il.com, gustavo@...eddedor.com, weic@...dia.com,
        mhosny@...dia.com, peng.ma@....com
Subject: Re: [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the
 DSPI controllers

Am 2020-03-09 15:56, schrieb Vladimir Oltean:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> LS1028A has a functional connection to the eDMA module. Even if the
> spi-fsl-dspi.c driver is not using DMA for LS1028A now, define the 
> slots
> in the DMAMUX for connecting the eDMA channels to the 3 DSPI
> controllers.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 515e0a1b934f..18155273a46e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -298,6 +298,8 @@
>  			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "dspi";
>  			clocks = <&clockgen 4 1>;
> +			dmas = <&edma0 0 62>, <&edma0 0 60>;
> +			dma-names = "tx", "rx";

minor nit. Other nodes specified the dma channels as

dma-names = "tx", "rx";
dmas = <&edma0 0 62>,
        <&edma0 0 60>;

-michael

>  			spi-num-chipselects = <4>;
>  			little-endian;
>  			status = "disabled";
> @@ -311,6 +313,8 @@
>  			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "dspi";
>  			clocks = <&clockgen 4 1>;
> +			dmas = <&edma0 0 58>, <&edma0 0 56>;
> +			dma-names = "tx", "rx";
>  			spi-num-chipselects = <4>;
>  			little-endian;
>  			status = "disabled";
> @@ -324,6 +328,8 @@
>  			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
>  			clock-names = "dspi";
>  			clocks = <&clockgen 4 1>;
> +			dmas = <&edma0 0 54>, <&edma0 0 2>;
> +			dma-names = "tx", "rx";
>  			spi-num-chipselects = <3>;
>  			little-endian;
>  			status = "disabled";