linux-kernel - Re: [PATCH] HID: logitech-dj: add support for the static device in the Powerplay mat/receiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Mar 2020 14:22:16 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Filipe Laíns <lains@...hlinux.org>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nestor Lopez Casado <nlopezcasad@...itech.com>
Subject: Re: [PATCH] HID: logitech-dj: add support for the static device in
 the Powerplay mat/receiver

On Wed, 12 Feb 2020, Filipe Laíns wrote:

> > > +	/* custom receiver device (eg. powerplay) */
> > > +	if (hidpp_report->device_index == 7) {
> > > +		workitem.reports_supported |= HIDPP;
> > > +	}
> > > +
> > 
> > I guess we can't do anything else than to trust Logitech that they will 
> > not assign conflicting device_index ID in the future to something that 
> > will not be HID++, right?
> > 
> > Or is this properly documented somewhere?
> > 
> > Thanks,
> 
> 
> CCing Nestor
> 
> Yes, we need to trust Logitech on this. There's isn't anything
> documented regarding this AFAIK.
> 
> Even if Logitech released a device with index 7 that didn't support
> HID++, it wouldn't be that big of an issue. We would just end up with a
> hidraw node which would export a vendor page report descriptor but the
> device wouldn't actually reply to anything.

Given the silence from Nestor, I guess we can just apply this for 5.7; 
pushing to for-5.7/logitech branch.

Thanks,

-- 
Jiri Kosina
SUSE Labs