linux-kernel - Re: [patch part-II V2 11/13] x86/speculation/mds: Mark mds_user_clear_cpu_buffers() __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9847c45-32b0-e5e6-1eb9-5f9e10814276@oracle.com>
Date:   Tue, 10 Mar 2020 14:48:35 +0100
From:   Alexandre Chartre <alexandre.chartre@...cle.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Steven Rostedt <rostedt@...dmis.org>,
        Brian Gerst <brgerst@...il.com>,
        Juergen Gross <jgross@...e.com>,
        Frederic Weisbecker <frederic@...nel.org>
Subject: Re: [patch part-II V2 11/13] x86/speculation/mds: Mark
 mds_user_clear_cpu_buffers() __always_inline


On 3/8/20 11:24 PM, Thomas Gleixner wrote:
> Prevent the compiler from uninlining and creating traceable/probable
> functions as this is invoked _after_ context tracking switched to
> CONTEXT_USER and rcu idle.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>   arch/x86/include/asm/nospec-branch.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/x86/include/asm/nospec-branch.h
> +++ b/arch/x86/include/asm/nospec-branch.h
> @@ -319,7 +319,7 @@ DECLARE_STATIC_KEY_FALSE(mds_idle_clear)
>    * combination with microcode which triggers a CPU buffer flush when the
>    * instruction is executed.
>    */
> -static inline void mds_clear_cpu_buffers(void)
> +static __always_inline void mds_clear_cpu_buffers(void)
>   {
>   	static const u16 ds = __KERNEL_DS;
>   
> @@ -340,7 +340,7 @@ static inline void mds_clear_cpu_buffers
>    *
>    * Clear CPU buffers if the corresponding static key is enabled
>    */
> -static inline void mds_user_clear_cpu_buffers(void)
> +static __always_inline void mds_user_clear_cpu_buffers(void)
>   {
>   	if (static_branch_likely(&mds_user_clear))
>   		mds_clear_cpu_buffers();
> 

Reviewed-by: Alexandre Chartre <alexandre.chartre@...cle.com>

I am just wondering if it would be worth defining a new function attribute to
identify functions which shouldn't be trace/probe more clearly. For example:

#define no_trace_and_probe __always_inline

static no_trace_and_probe void mds_user_clear_cpu_buffers(void)
{
         ...
}

I am just concerned that overtime we might forgot that a function is defined
__always_inline just because it shouldn't be traced/probed.

alex.