linux-kernel - Re: [PATCH 2/2] USB: EHCI: ehci-mv: use a unique bus name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.2003101003490.1651-100000@iolanthe.rowland.org>
Date:   Tue, 10 Mar 2020 10:04:04 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Lubomir Rintel <lkundrak@...sk>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] USB: EHCI: ehci-mv: use a unique bus name

On Mon, 9 Mar 2020, Lubomir Rintel wrote:

> In case there are multiple Marvell EHCI blocks in system, we need a
> different bus name for each one. Otherwise debugfs gets mildly upset about
> a directory name in usb/ehci:
> 
>   debugfs: Directory 'mv ehci' with parent 'ehci' already present!
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>

Acked-by: Alan Stern <stern@...land.harvard.edu>

> ---
>  drivers/usb/host/ehci-mv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index ddb668963955f..1300c457d9ed6 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -115,7 +115,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
>  	if (usb_disabled())
>  		return -ENODEV;
>  
> -	hcd = usb_create_hcd(&ehci_platform_hc_driver, &pdev->dev, "mv ehci");
> +	hcd = usb_create_hcd(&ehci_platform_hc_driver, &pdev->dev, dev_name(&pdev->dev));
>  	if (!hcd)
>  		return -ENOMEM;
>  
>