linux-kernel - Re: [v1 3/3] media: ov8856: Implement sensor module revision identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Mar 2020 16:30:14 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Robert Foss <robert.foss@...aro.org>
Cc:     ben.kao@...el.com, mchehab@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, matthias.bgg@...il.com, davem@...emloft.net,
        gregkh@...uxfoundation.org, Jonathan.Cameron@...wei.com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Dongchun Zhu <dongchun.zhu@...iatek.com>,
        Tomasz Figa <tfiga@...omium.org>
Subject: Re: [v1 3/3] media: ov8856: Implement sensor module revision
 identification

On Tue, Mar 10, 2020 at 02:46:03PM +0100, Robert Foss wrote:
> Query the sensor for its module revision, and compare it
> to known revisions.
> Currently only the '1B' revision has been added.

Are you sure you send latest version?

I have a déjà vu that I have seen this already and this one doesn't address any
comment given.

...

> +	dev_info(&client->dev, "OV8856 revision %x (%s) at address 0x%02x\n",
> +		val,

> +		val == OV8856_1B_MODULE ? "1B" : "unknown revision",

This is weird. Can you add a bit more general way of showing revision?

> +		client->addr);

-- 
With Best Regards,
Andy Shevchenko