linux-kernel - Re: [PATCH 5.5 175/189] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310150512.GC14211@localhost>
Date:   Tue, 10 Mar 2020 16:05:12 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sanchayan Maity <maitysanchayan@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Johan Hovold <johan@...nel.org>,
        Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
Subject: Re: [PATCH 5.5 175/189] ARM: dts: imx6dl-colibri-eval-v3: fix sram
 compatible properties

On Tue, Mar 10, 2020 at 01:40:12PM +0100, Greg Kroah-Hartman wrote:
> From: Johan Hovold <johan@...nel.org>
> 
> commit bcbf53a0dab50980867476994f6079c1ec5bb3a3 upstream.
> 
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
> 
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
> 
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
> 
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <maitysanchayan@...il.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
> Signed-off-by: Shawn Guo <shawnguo@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

This was never meant to go into stable so I didn't add a stable CC-tag.

It causes a driver to bind to the corresponding platform devices, which
have so far been unbound and may therefore have unwanted side-effects.

I don't think it's stable material either way.

> ---
>  arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -275,7 +275,7 @@
>  
>  	/* SRAM on Colibri nEXT_CS0 */
>  	sram@0,0 {
> -		compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +		compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>  		reg = <0 0 0x00010000>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> @@ -286,7 +286,7 @@
>  
>  	/* SRAM on Colibri nEXT_CS1 */
>  	sram@1,0 {
> -		compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +		compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>  		reg = <1 0 0x00010000>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> 
> 

Johan