linux-kernel - Re: [PATCH] loop: Only change blocksize when needed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB5749104A80045EB0BD3EB28886FF0@BYAPR04MB5749.namprd04.prod.outlook.com>
Date:   Tue, 10 Mar 2020 20:23:46 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Martijn Coenen <maco@...roid.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>, "hch@....de" <hch@....de>
CC:     "bvanassche@....org" <bvanassche@....org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-team@...roid.com" <kernel-team@...roid.com>
Subject: Re: [PATCH] loop: Only change blocksize when needed.

Logically this is a right thing to do, but I wonder how much speedup
you are getting with these improvements ?
It will be great if you have some numbers so we all know the speedup.

Irrespective of that, this looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 03/10/2020 06:17 AM, Martijn Coenen wrote:
> Return early in loop_set_block_size() if the requested block size is
> identical to the one we already have; this avoids expensive calls to
> freeze the block queue.
>
> Signed-off-by: Martijn Coenen<maco@...roid.com>