linux-kernel - Re: [PATCH v3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310172114-mutt-send-email-mst@kernel.org>
Date:   Tue, 10 Mar 2020 17:25:25 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     David Rientjes <rientjes@...gle.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, virtualization@...ts.linux-foundation.org,
        Jason Wang <jasowang@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Tyler Sanderson <tysand@...gle.com>,
        Wei Wang <wei.w.wang@...el.com>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Nadav Amit <namit@...are.com>,
        Michal Hocko <mhocko@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3] virtio-balloon: Switch back to OOM handler for
 VIRTIO_BALLOON_F_DEFLATE_ON_OOM

On Tue, Mar 10, 2020 at 08:13:19PM +0100, David Hildenbrand wrote:
> > Should this have:
> > 
> > Cc: stable@...r.kernel.org # 4.19+
> 
> I guess as nothing will actually "crash" it's not worth stable.


No - it's a regression, it would be a stable candidate from that POV.
The issue is the patch size - stable rules say:

 - It cannot be bigger than 100 lines, with context.

This is about 200 lines with context.
In practice Fixes: is enough to make a bunch of downstreams pick it up.

-- 
MST