linux-kernel - Re: [PATCH v7 6/7] mm/madvise: employ mmget_still

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310222815.GD72963@google.com>
Date:   Tue, 10 Mar 2020 15:28:15 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Oleksandr Natalenko <oleksandr@...hat.com>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>, linux-api@...r.kernel.org,
        Suren Baghdasaryan <surenb@...gle.com>,
        Tim Murray <timmurray@...gle.com>,
        Daniel Colascione <dancol@...gle.com>,
        Sandeep Patil <sspatil@...gle.com>,
        Sonny Rao <sonnyrao@...gle.com>,
        Brian Geffon <bgeffon@...gle.com>,
        Michal Hocko <mhocko@...e.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        John Dias <joaodias@...gle.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Jann Horn <jannh@...gle.com>,
        alexander.h.duyck@...ux.intel.com, sj38.park@...il.com
Subject: Re: [PATCH v7 6/7] mm/madvise: employ mmget_still_valid for write
 lock

On Mon, Mar 09, 2020 at 01:30:45PM +0100, Oleksandr Natalenko wrote:
> On Fri, Mar 06, 2020 at 05:03:50PM +0100, Vlastimil Babka wrote:
> > On 3/6/20 2:03 PM, Oleksandr Natalenko wrote:
> > > Hello.
> > > 
> > > On Fri, Mar 06, 2020 at 01:52:07PM +0100, Vlastimil Babka wrote:
> > >> > diff --git a/mm/madvise.c b/mm/madvise.c
> > >> > index e794367f681e..e77c6c1fad34 100644
> > >> > --- a/mm/madvise.c
> > >> > +++ b/mm/madvise.c
> > >> > @@ -1118,6 +1118,8 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm,
> > >> >  	if (write) {
> > >> >  		if (down_write_killable(&mm->mmap_sem))
> > >> >  			return -EINTR;
> > >> > +		if (current->mm != mm && !mmget_still_valid(mm))
> > >> > +			goto skip_mm;
> > >> 
> > >> This will return 0, is that correct? Shoudln't there be a similar error e.g. as
> > >> when finding the task by pid fails (-ESRCH ?), because IIUC the task here is
> > >> going away and dumping the core?
> > > 
> > > Yeah.
> > > 
> > > Something like this then:
> > > 
> > > ===
> > > diff --git a/mm/madvise.c b/mm/madvise.c
> > > index 48d1da08c160..7ed2f4d13924 100644
> > > --- a/mm/madvise.c
> > > +++ b/mm/madvise.c
> > > @@ -1122,6 +1122,10 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm,
> > >  	if (write) {
> > >  		if (down_write_killable(&mm->mmap_sem))
> > >  			return -EINTR;
> > > +		if (current->mm != mm && !mmget_still_valid(mm)) {
> > > +			error = -ESRCH;
> > > +			goto skip_mm;
> > > +		}
> > >  	} else {
> > >  		down_read(&mm->mmap_sem);
> > >  	}
> > > @@ -1173,6 +1177,7 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm,
> > >  	}
> > >  out:
> > >  	blk_finish_plug(&plug);
> > > +skip_mm:
> > >  	if (write)
> > >  		up_write(&mm->mmap_sem);
> > >  	else
> > > 
> > > ===
> > > 
> > > ?
> > 
> > Yep, thanks.
> > 
> 
> Minchan, shall you take this change into the next submission, or you'd
> prefer me sending it to you as a new patch?

I should send patchset again so I will take it.
Thanks!