linux-kernel - Re: [PATCH v2 06/14] net: axienet: Factor out TX descriptor chain cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200309.174816.1763845933351180364.davem@davemloft.net>
Date:   Mon, 09 Mar 2020 17:48:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andre.przywara@....com
Cc:     radhey.shyam.pandey@...inx.com, michal.simek@...inx.com,
        hancock@...systems.ca, netdev@...r.kernel.org,
        rmk+kernel@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, andrew@...n.ch
Subject: Re: [PATCH v2 06/14] net: axienet: Factor out TX descriptor chain
 cleanup

From: Andre Przywara <andre.przywara@....com>
Date: Mon,  9 Mar 2020 18:18:43 +0000

> -static void axienet_start_xmit_done(struct net_device *ndev)
> +static int axienet_free_tx_chain(struct net_device *ndev, u32 first_bd,
> +				 int nr_bds, u32 *sizep)
>  {
> -	u32 size = 0;
> -	u32 packets = 0;
>  	struct axienet_local *lp = netdev_priv(ndev);
> +	int max_bds = (nr_bds != -1) ? nr_bds : lp->tx_bd_num;
>  	struct axidma_bd *cur_p;
> -	unsigned int status = 0;
> +	unsigned int status;
> +	int i;

Please use reverse christms tree ordering for local variable
declarations.

> +static void axienet_start_xmit_done(struct net_device *ndev)
> +{
> +	u32 size = 0;
> +	u32 packets = 0;
> +	struct axienet_local *lp = netdev_priv(ndev);

Likewise.