linux-kernel - Re: linux-next: build warning after merge of the vfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310103225.GA2692297@kroah.com>
Date:   Tue, 10 Mar 2020 11:32:25 +0100
From:   'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     'Pali Rohár' <pali@...nel.org>,
        'Stephen Rothwell' <sfr@...b.auug.org.au>,
        'Al Viro' <viro@...iv.linux.org.uk>,
        'Linux Next Mailing List' <linux-next@...r.kernel.org>,
        'Linux Kernel Mailing List' <linux-kernel@...r.kernel.org>,
        'Sungjong Seo' <sj1557.seo@...sung.com>,
        'Christoph Hellwig' <hch@....de>
Subject: Re: linux-next: build warning after merge of the vfs tree

On Tue, Mar 10, 2020 at 08:36:04AM +0900, Namjae Jeon wrote:
> > On Tuesday 10 March 2020 09:59:18 Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the vfs tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > warning: same module names found:
> > >   fs/exfat/exfat.ko
> > >   drivers/staging/exfat/exfat.ko
> > >
> > > Introduced by commit
> > >
> > >   b9d1e2e6265f ("exfat: add Kconfig and Makefile")
> > >
> > > and not fixed by commit
> > >
> > >   1a3c0509ce83 ("staging: exfat: make staging/exfat and fs/exfat
> > > mutually exclusive")
> > 
> > Hello Stephen!
> > 
> > exfat.ko from fs/exfat subdirectory is a rewrite/cleanup of staging exfat
> > driver. It means that fs/exfat replaces staging/exfat and so after
> > fs/exfat is merged, the old staging/exfat code is not needed anymore.
> > 
> > Therefore I think that instead of hacking Kconfig/Makefile files to define
> > mutually exclusivity, it is better to remove staging/exfat code.
> > 
> > Removal of old staging code should be easy and should fix this problem.
> Agree.
> Greg, You told me to let me know when fs/exfat gets accepted. Now it's time
> to drop staging/exfat.

Wonderful!  I'll go drop it right now, thanks for letting me know!

greg k-h