linux-kernel - Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2003101251500.19500@cbobk.fhfr.pm>
Date:   Tue, 10 Mar 2020 12:53:21 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Tony Fischetti <tony.fischetti@...il.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse

On Wed, 4 Mar 2020, Tony Fischetti wrote:

> A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
> where it disconnects and reconnects every minute--each time incrementing
> the device number. This patch adds the device id of the device and
> specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
> work properly.

You are missing Signed-off-by: line here (please see 
Documentation/process/5.Posting.rst and 
Documentation/process/submitting-patches.rst to read what this is about).

Also, we generally prefix all the patches to HID susbsytem with 'HID: ' in 
the subject / shortlog, so as you'll be resending with signoff, could you 
please fix that up at the same time as well?

Thanks,

-- 
Jiri Kosina
SUSE Labs