linux-kernel - Re: Re: [PATCH v6 07/14] mm/damon: Implement kernel space API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Mar 2020 12:56:20 +0100
From:   SeongJae Park <sjpark@...zon.com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
CC:     SeongJae Park <sjpark@...zon.com>, <akpm@...ux-foundation.org>,
        "SeongJae Park" <sjpark@...zon.de>, <aarcange@...hat.com>,
        <yang.shi@...ux.alibaba.com>, <acme@...nel.org>,
        <alexander.shishkin@...ux.intel.com>, <amit@...nel.org>,
        <brendan.d.gregg@...il.com>, <brendanhiggins@...gle.com>,
        <cai@....pw>, <colin.king@...onical.com>, <corbet@....net>,
        <dwmw@...zon.com>, <jolsa@...hat.com>, <kirill@...temov.name>,
        <mark.rutland@....com>, <mgorman@...e.de>, <minchan@...nel.org>,
        <mingo@...hat.com>, <namhyung@...nel.org>, <peterz@...radead.org>,
        <rdunlap@...radead.org>, <rientjes@...gle.com>,
        <rostedt@...dmis.org>, <shuah@...nel.org>, <sj38.park@...il.com>,
        <vbabka@...e.cz>, <vdavydov.dev@...il.com>, <linux-mm@...ck.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH v6 07/14] mm/damon: Implement kernel space API

On Tue, 10 Mar 2020 09:01:52 +0000 Jonathan Cameron <Jonathan.Cameron@...wei.com> wrote:

> On Mon, 24 Feb 2020 13:30:40 +0100
> SeongJae Park <sjpark@...zon.com> wrote:
> 
> > From: SeongJae Park <sjpark@...zon.de>
> > 
> > This commit implements the DAMON api for the kernel.  Other kernel code
> > can use DAMON by calling damon_start() and damon_stop() with their own
> > 'struct damon_ctx'.
> > 
> > Signed-off-by: SeongJae Park <sjpark@...zon.de>
> 
> Seems like it would have been easier to create the header as you went along
> and avoid the need to have the bits here dropping static.

Yes, exporing the API from the beginning must be much simpler and easy to
review!

> 
> Or the moves for that matter.
> 
> Also, ideally have full kernel-doc for anything that forms part of an
> interface that is intended for use by others.

Agreed, will use the kernel-doc comments!


Thanks,
SeongJae Park

> 
> Jonathan
> 
> > ---
[...]