linux-kernel - Re: [PATCH v3 1/1] scsi: ufs: fix LRB pointer incorrect initialization issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ede4addf-73c7-e5f8-5143-91eb0cd3eb9b@acm.org>
Date:   Mon, 9 Mar 2020 18:58:11 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     huobean@...il.com, alim.akhtar@...sung.com, avri.altman@....com,
        asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] scsi: ufs: fix LRB pointer incorrect
 initialization issue

On 2020-03-09 09:10, huobean@...il.com wrote:
> @@ -4834,6 +4829,7 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
>  			continue;
>  		cmd = blk_mq_rq_to_pdu(req);
>  		lrbp = scsi_cmd_priv(cmd);
> +		ufshcd_init_lrb(hba, lrbp, index);
>  		if (ufshcd_is_scsi(req)) {
>  			ufshcd_add_command_trace(hba, req, "complete");
>  			result = ufshcd_transfer_rsp_status(hba, lrbp);

This ufshcd_init_lrb() call looks incorrect to me. I think that
ufshcd_init_lrb() should only be called before a request is submitted to
the UFS controller and also that ufshcd_init_lrb() should not be called
from the completion path.

Thanks,

Bart.