linux-kernel - Re[PATCH 3/6] KVM: nVMX: properly handle errors in nested_vmx_handle_enlightened

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 10 Mar 2020 02:38:16 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
CC:     Paolo Bonzini <pbonzini@...hat.com>,
        Jim Mattson <jmattson@...gle.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Liran Alon <liran.alon@...cle.com>
Subject: Re[PATCH 3/6] KVM: nVMX: properly handle errors in
 nested_vmx_handle_enlightened_vmptrld()

Hi:
Vitaly Kuznetsov <vkuznets@...hat.com> writes:
>nested_vmx_handle_enlightened_vmptrld() fails in two cases:
>- when we fail to kvm_vcpu_map() the supplied GPA
>- when revision_id is incorrect.
>Genuine Hyper-V raises #UD in the former case (at least with *some* incorrect GPAs) and does VMfailInvalid() in the later. KVM doesn't do anything so L1 just gets stuck retrying the same faulty VMLAUNCH.
>
>nested_vmx_handle_enlightened_vmptrld() has two call sites:
>nested_vmx_run() and nested_get_vmcs12_pages(). The former needs to queue do much: the failure there happens after migration when L2 was running (and
>L1 did something weird like wrote to VP assist page from a different vCPU), just kill L1 with KVM_EXIT_INTERNAL_ERROR.
>
>Reported-by: Miaohe Lin <linmiaohe@...wei.com>
>Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Thanks for fixing this issue!:) The code looks fine for and it should works as far as I can say.
Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>