linux-kernel - Re: [PATCH] kmod: make request_module() return an error when autoloading is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200311174134.GB20006@gmail.com>
Date:   Wed, 11 Mar 2020 10:41:34 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        stable@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeff Vander Stoep <jeffv@...gle.com>,
        Jessica Yu <jeyu@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH] kmod: make request_module() return an error when
 autoloading is disabled

On Wed, Mar 11, 2020 at 10:28:07AM -0700, Kees Cook wrote:
> On Tue, Mar 10, 2020 at 03:37:31PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > It's long been possible to disable kernel module autoloading completely
> > by setting /proc/sys/kernel/modprobe to the empty string.  This can be
> 
> Hunh. I've never seen that before. :) I've always used;
> 
> echo 1 > /proc/sys/kernel/modules_disabled
> 
> Regardless,
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 

modules_disabled is different because it disables *all* module loading, not just
autoloading.

- Eric