linux-kernel - Re: [PATCH v6 10/14] KVM: selftests: Use a single binary for dirty/clear log test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200311184703.gbjncvlusef44tqk@kamzik.brq.redhat.com>
Date:   Wed, 11 Mar 2020 19:47:03 +0100
From:   Andrew Jones <drjones@...hat.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Yan Zhao <yan.y.zhao@...el.com>,
        Jason Wang <jasowang@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        Christophe de Dinechin <dinechin@...hat.com>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [PATCH v6 10/14] KVM: selftests: Use a single binary for
 dirty/clear log test

On Wed, Mar 11, 2020 at 01:43:24PM -0400, Peter Xu wrote:
> > >  
> > > +	if (!log_mode_supported()) {
> > > +		fprintf(stderr, "Log mode '%s' not supported, skip\n",
> > > +			log_modes[host_log_mode].name);
> > 
> > I think kvm selftests needs a skip_test() function that outputs a more
> > consistent test skip message. It seems we mostly do
> 
> Yep, I can introduce one.

I already did. Right after suggesting it.

https://www.spinics.net/lists/kvm/msg209545.html

Thanks,
drew