linux-kernel - Re: [PATCH v9 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1583897091.14612.1.camel@mtksdaap41>
Date:   Wed, 11 Mar 2020 11:24:51 +0800
From:   Yingjoe Chen <yingjoe.chen@...iatek.com>
To:     Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
CC:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        "Alessandro Zummo" <a.zummo@...ertech.it>,
        Josef Friedl <josef.friedl@...ed.at>,
        "Nicolas Boichat" <drinkcat@...omium.org>,
        <srv_heupstream@...iatek.com>,
        "Frank Wunderlich" <frank-w@...lic-files.de>,
        Ran Bi <ran.bi@...iatek.com>,
        "Sean Wang" <sean.wang@...iatek.com>,
        Sebastian Reichel <sre@...nel.org>,
        <linux-kernel@...r.kernel.org>,
        Richard Fontana <rfontana@...hat.com>,
        <devicetree@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-pm@...r.kernel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Eddie Huang <eddie.huang@...iatek.com>,
        <linux-rtc@...r.kernel.org>
Subject: Re: [PATCH v9 4/5] rtc: mt6397: Add support for the MediaTek MT6358
 RTC

On Tue, 2020-03-10 at 18:10 +0800, Hsin-Hsiung Wang wrote:
> From: Ran Bi <ran.bi@...iatek.com>
> 
> This add support for the MediaTek MT6358 RTC. Driver using
> compatible data to store different RTC_WRTGR address offset.
> This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff
> driver which only needed by armv7 CPU without ATF.
> 
> Signed-off-by: Ran Bi <ran.bi@...iatek.com>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
> ---

<...>

> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> index 7dfb63b..3dc48e8 100644
> --- a/include/linux/mfd/mt6397/rtc.h
> +++ b/include/linux/mfd/mt6397/rtc.h

<...>

> +
> +static const struct mtk_rtc_data mt6358_rtc_data = {
> +	.wrtgr = RTC_WRTGR_MT6358,
> +};
> +
> +static const struct mtk_rtc_data mt6397_rtc_data = {
> +	.wrtgr = RTC_WRTGR_MT6397,
>  };

Hi,

mt6323-poweroff.c doesn't need these _rtc_data. Please put them in
rtc-mt6397.c

Joe.C