linux-kernel - Re: [RESEND][PATCH v8 1/6] usb: dwc3: Registering a role switch in the DRD code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLU0HWYsZcOjBj3XRy6+D33aPuQ=+hF=gv0prUquyb1+pg@mail.gmail.com>
Date:   Wed, 11 Mar 2020 12:54:26 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>, Yu Chen <chenyu56@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        ShuFan Lee <shufan_lee@...htek.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Felipe Balbi <balbi@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Jun Li <lijun.kernel@...il.com>,
        Valentin Schneider <valentin.schneider@....com>,
        Guillaume Gardet <Guillaume.Gardet@....com>,
        Jack Pham <jackp@...eaurora.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [RESEND][PATCH v8 1/6] usb: dwc3: Registering a role switch in
 the DRD code.

On Wed, Mar 11, 2020 at 12:44 PM John Stultz <john.stultz@...aro.org> wrote:
>
> On Wed, Mar 11, 2020 at 12:17 PM Bryan O'Donoghue
> <bryan.odonoghue@...aro.org> wrote:
> >
> > > +static int dwc3_usb_role_switch_set(struct device *dev, enum usb_role role)
> >
> > @bjorn found an API change that explodes this one.
> >
> > Fixed here: https://lkml.org/lkml/2020/3/11/1034
>
> Huh. I wonder why I don't see that causing trouble in my testing.  :/
>
> Oddly, trying to use your patch results in build failures for me... Is
> the api change something in -next?

Ah. Ok, I found it: "usb: roles: Provide the switch drivers handle to
the switch in the API"

I'll add that to my patch series, retest and resubmit. Thanks for the heads up!
-john