linux-kernel - Re: [PATCH v2] power: supply: Allow charger manager can be built as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Mar 2020 23:18:56 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Baolin Wang <baolin.wang7@...il.com>
Cc:     Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Android Kernel Team <kernel-team@...roid.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] power: supply: Allow charger manager can be built as
 a module

Hi,

On Mon, Mar 09, 2020 at 11:20:41AM +0800, Baolin Wang wrote:
> On Sat, Mar 7, 2020 at 4:47 AM Sebastian Reichel <sre@...nel.org> wrote:
> > On Fri, Mar 06, 2020 at 10:34:10AM +0800, Baolin Wang wrote:
> > > Allow charger manager can be built as a module like other charger
> > > drivers.
> > >
> > > Signed-off-by: Baolin Wang <baolin.wang7@...il.com>
> > > ---
> >
> > Thanks, queued. I do not like this driver, but its the best we have
> > at the moment.
> 
> Thanks. I understood your concern, do you have any plan to re-design
> the charger manager driver in kernel? Or do you have some thoughts
> about re-designing it? Now we have some out of tree code to use the
> old charger manger, and we'd like to change to the new charger manger
> driver and upstream them.

I don't have anything ready yet and not enough time unfortunately.
The proper way would be to have something equivialent to charger-manager
in the power-supply core. The core should be able to monitor batteries
and handle connected chargers automatically.  Also there shouldn't be
any DT entry for the software managing the charger, since DT is about
hardware.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)