linux-kernel - Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Mar 2020 04:00:40 +0530
From:   Shreeya Patel <shreeya.patel23498@...il.com>
To:     outreachy-kernel@...glegroups.com,
        Stefano Brivio <sbrivio@...hat.com>
CC:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, daniel.baluta@...il.com,
        nramas@...ux.microsoft.com, hverkuil@...all.nl,
        Larry.Finger@...inger.net
Subject: Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators



On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
 <sbrivio@...hat.com> wrote:

Hey Stefano,

>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel <shreeya.patel23498@...il.com> wrote:
>
>> Add space around operators for improving the code
>> readability.
>> Reported by checkpatch.pl
>> 
>> git diff -w shows no difference.
>> diff of the .o files before and after the changes shows no
>difference.
>> 
>> Signed-off-by: Shreeya Patel <shreeya.patel23498@...il.com>
>
>This looks good to me. Further clean-ups here could probably make this
>look less messy (there are long lines, unnecessary parentheses that are
>rather confusing, especially on that 4/5 factor, "magic" constants that
>might make sense to figure out the meaning of, etc.).
>

Thanks for reviewing. I will surely look at the other clean-ups as well :)

Thanks

>Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.