linux-kernel - Re: [PATCH v3 2/3] dt-bindings: power: supply: add cw2015

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd1bea1c-e42b-8ccc-7fbb-2ed268f1b1a5@manjaro.org>
Date:   Thu, 12 Mar 2020 00:17:55 +0100
From:   Tobias Schramm <t.schramm@...jaro.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>,
        Tobias Schramm <t.schramm@...jaro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Mark Brown <broonie@...nel.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: power: supply: add cw2015_battery
 bindings

Hi Daniel,

thanks for reviewing. The typo will be fixed for v4.

>> +  power-supplies:
>> +    description:
>> +      Specifies supplies used for charging the battery connected to this gauge
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/phandle-array
>> +      - minItems: 1
>> +        maxItems: 8 # Should be enough
> 
> Is it necessary to set a maximum? power_supply.txt is still a text file
> but there is no mention of a maximum there.
> 
I think so? Removing maxItems and running dtbs_check on a dts with more
than one supply phandle in the power-supplies property results in an error:
linux/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dt.yaml:
cw2015@62: power-supplies: [[142], [50]] is too long

Best Regards,

Tobias