linux-kernel - Re: [PATCH] kmod: make request_module() return an error when autoloading is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200311063214.GM11244@42.do-not-panic.com>
Date:   Wed, 11 Mar 2020 06:32:14 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Josh Triplett <josh@...htriplett.org>
Cc:     Eric Biggers <ebiggers@...nel.org>, NeilBrown <neilb@...e.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        stable@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeff Vander Stoep <jeffv@...gle.com>,
        Jessica Yu <jeyu@...nel.org>,
        Kees Cook <keescook@...omium.org>, benh@...ian.org
Subject: Re: [PATCH] kmod: make request_module() return an error when
 autoloading is disabled

On Wed, Mar 11, 2020 at 06:55:30AM +0100, Josh Triplett wrote:
> On March 11, 2020 5:32:21 AM GMT+01:00, Luis Chamberlain <mcgrof@...nel.org> wrote:
> >On Tue, Mar 10, 2020 at 03:37:31PM -0700, Eric Biggers wrote: 
> >> However, request_module() should also
> >> correctly return an error when it fails.  So let's make it return
> >> -ENOENT, which matches the error when the modprobe binary doesn't
> >exist.
> >
> >This is a user experience change though, and I wouldn't have on my
> >radar
> >who would use this, and expects the old behaviour. Josh, would you by
> >chance?
> 
> I don't think this affects userspace. But I'd suggest Ben Hutchings (CCed).

It doesn't, so yes no verififcation needed. Thanks the quick response though!

  Luis