lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 11 Mar 2020 07:07:39 +0000
From:   Peng Fan <peng.fan@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anson Huang <anson.huang@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        Daniel Baluta <daniel.baluta@....com>
Subject: RE: [PATCH] ARM64: dts: imx8m: fix aips dts node

Hi Shawn,

> Subject: Re: [PATCH] ARM64: dts: imx8m: fix aips dts node
> 
> On Tue, Feb 25, 2020 at 11:44:02AM +0800, peng.fan@....com wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Per binding doc fsl,aips-bus.yaml, compatible and reg is
> 
> Where can I find this binding doc?

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=db1b4b3a7ae19d1abc6d52e9b3dc05b4bb99320f

> 
> > required. And for reg, the AIPS configuration space should be used,
> > not all the AIPS bus space.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> 
> Prefix 'arm64: ...' for arch/arm64 patches.

Could you please help correct or should I submit v2?

Thanks,
Peng.

> 
> Shawn
> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 12 ++++++++----
> > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 16 ++++++++--------
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 12 ++++++++----
> >  4 files changed, 30 insertions(+), 22 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index b3d0b29d7007..a4356d2047cd 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -227,7 +227,8 @@
> >  		ranges = <0x0 0x0 0x0 0x3e000000>;
> >
> >  		aips1: bus@...00000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30000000 0x30000000 0x400000>; @@ -496,7
> +497,8 @@
> >  		};
> >
> >  		aips2: bus@...00000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30400000 0x30400000 0x400000>; @@ -555,7
> +557,8 @@
> >  		};
> >
> >  		aips3: bus@...00000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30800000 0x30800000 0x400000>; @@ -800,7
> +803,8 @@
> >  		};
> >
> >  		aips4: bus@...00000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x32df0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x32c00000 0x32c00000 0x400000>; diff --git
> > a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > index f2775724377f..4848ce82f083 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > @@ -203,8 +203,8 @@
> >  		ranges = <0x0 0x0 0x0 0x3e000000>;
> >
> >  		aips1: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30000000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -401,8 +401,8 @@
> >  		};
> >
> >  		aips2: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30400000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -461,8 +461,8 @@
> >  		};
> >
> >  		aips3: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30800000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -707,8 +707,8 @@
> >  		};
> >
> >  		aips4: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x32c00000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x32df0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 71b0c8f23693..eb67f56cdfe2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -144,8 +144,8 @@
> >  		ranges = <0x0 0x0 0x0 0x3e000000>;
> >
> >  		aips1: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30000000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -309,8 +309,8 @@
> >  		};
> >
> >  		aips2: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30400000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x400000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -369,8 +369,8 @@
> >  		};
> >
> >  		aips3: bus@...00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30800000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x400000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 6a1e83922c71..07070464063d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -290,7 +290,8 @@
> >  		dma-ranges = <0x40000000 0x0 0x40000000 0xc0000000>;
> >
> >  		bus@...00000 { /* AIPS1 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30000000 0x30000000 0x400000>; @@ -692,7
> +693,8 @@
> >  		};
> >
> >  		bus@...00000 { /* AIPS2 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30400000 0x30400000 0x400000>; @@ -751,7
> +753,8 @@
> >  		};
> >
> >  		bus@...00000 { /* AIPS3 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30800000 0x30800000 0x400000>, @@ -1023,7
> +1026,8 @@
> >  		};
> >
> >  		bus@...00000 { /* AIPS4 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x32df0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x32c00000 0x32c00000 0x400000>;
> > --
> > 2.16.4
> >

Powered by blists - more mailing lists