linux-kernel - Re: [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200311071613.GL29269@dragon>
Date:   Wed, 11 Mar 2020 15:16:14 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Michael Walle <michael@...le.cc>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Li Yang <leoyang.li@....com>
Subject: Re: [PATCH 1/3] arm64: dts: ls1028a: sl28: fix on-board EEPROMS

On Tue, Feb 25, 2020 at 06:57:54PM +0100, Michael Walle wrote:
> The module itself has another EEPROM at 50h on I2C4. The EEPROM on the
> carriers is located at 57h on I2C3. Fix that in the device trees.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>

Doesn't apply to my branch.

Shawn

> ---
>  .../fsl-ls1028a-kontron-kbox-a-230-ls.dts          |  6 +++---
>  .../fsl-ls1028a-kontron-sl28-var3-ads2.dts         | 14 ++++++++------
>  .../dts/freescale/fsl-ls1028a-kontron-sl28.dts     |  6 ++++++
>  3 files changed, 17 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> index aaf3c04771c3..32f6c80414bc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -18,10 +18,10 @@
>  		     "kontron,sl28", "fsl,ls1028a";
>  };
>  
> -&i2c4 {
> -	eeprom@50 {
> +&i2c3 {
> +	eeprom@57 {
>  		compatible = "atmel,24c32";
> -		reg = <0x50>;
> +		reg = <0x57>;
>  		pagesize = <32>;
>  	};
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> index 20fd86746f94..ff4a43986290 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> @@ -80,6 +80,14 @@
>  	};
>  };
>  
> +&i2c3 {
> +	eeprom@57 {
> +		compatible = "atmel,24c64";
> +		reg = <0x57>;
> +		pagesize = <32>;
> +	};
> +};
> +
>  &i2c4 {
>  	status = "okay";
>  
> @@ -92,12 +100,6 @@
>  		assigned-clocks = <&mclk>;
>  		assigned-clock-rates = <1250000>;
>  	};
> -
> -	eeprom@50 {
> -		compatible = "atmel,24c32";
> -		reg = <0x50>;
> -		pagesize = <32>;
> -	};
>  };
>  
>  &sai5 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index c60a444ad09d..4ba6aae45ef1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -181,6 +181,12 @@
>  
>  &i2c4 {
>  	status = "okay";
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c32";
> +		reg = <0x50>;
> +		pagesize = <32>;
> +	};
>  };
>  
>  &lpuart1 {
> -- 
> 2.20.1
>