lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Mar 2020 11:05:50 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Robert Foss <robert.foss@...aro.org> Cc: ben.kao@...el.com, mchehab@...nel.org, robh+dt@...nel.org, mark.rutland@....com, matthias.bgg@...il.com, davem@...emloft.net, gregkh@...uxfoundation.org, Jonathan.Cameron@...wei.com, linux-media@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, Dongchun Zhu <dongchun.zhu@...iatek.com>, Tomasz Figa <tfiga@...omium.org> Subject: Re: [v1 2/3] media: ov8856: Add devicetree support On Tue, Mar 10, 2020 at 04:55:20PM +0100, Robert Foss wrote: > On Tue, 10 Mar 2020 at 15:26, Andy Shevchenko > <andriy.shevchenko@...ux.intel.com> wrote: > > On Tue, Mar 10, 2020 at 02:46:02PM +0100, Robert Foss wrote: ... > > > + ov8856->xvclk = devm_clk_get(&client->dev, "xvclk"); > > > + if (IS_ERR(ov8856->xvclk)) { > > > + dev_err(&client->dev, "failed to get xvclk\n"); > > > + return -EINVAL; > > > + } > > > > Previously it worked without clock provider, now you make a dependency. > > > > This won't work. > > So the ideal behavior would be to only use the xclk if it is provided? Yes, make it optional. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists