linux-kernel - Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e30f8a7-7334-494b-7ef6-205f5d6d4d36@suse.com>
Date:   Wed, 11 Mar 2020 14:26:04 +0100
From:   Matthias Brugger <mbrugger@...e.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        robh+dt@...nel.org, mark.rutland@....com, ck.hu@...iatek.com,
        p.zabel@...gutronix.de, airlied@...ux.ie, mturquette@...libre.com,
        sboyd@...nel.org, ulrich.hecht+renesas@...il.com,
        laurent.pinchart@...asonboard.com
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        linux-media@...r.kernel.org, Allison Randal <allison@...utok.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mediatek@...ts.infradead.org,
        Collabora Kernel ML <kernel@...labora.com>,
        dri-devel@...ts.freedesktop.org,
        Seiya Wang <seiya.wang@...iatek.com>,
        linux-kernel@...r.kernel.org, wens@...e.org,
        Daniel Vetter <daniel@...ll.ch>, linux-clk@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        devicetree@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        frank-w@...lic-files.de, linux-arm-kernel@...ts.infradead.org,
        hsinyi@...omium.org, Richard Fontana <rfontana@...hat.com>,
        mtk01761 <wendell.lin@...iatek.com>,
        Weiyi Lu <weiyi.lu@...iatek.com>, sean.wang@...iatek.com,
        rdunlap@...radead.org, matthias.bgg@...nel.org,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        Houlong Wei <houlong.wei@...iatek.com>,
        Minghsiu Tsai <minghsiu.tsai@...iatek.com>
Subject: Re: [PATCH v11 5/5] soc / drm: mediatek: Fix mediatek-drm device
 probing



On 11/03/2020 12:56, Enric Balletbo i Serra wrote:
> In the actual implementation the same compatible string
> "mediatek,<chip>-mmsys" is used to bind the clock drivers
> (drivers/soc/mediatek) as well as to the gpu driver
> (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends with the problem
> that the only probed driver is the clock driver and there is no display
> at all.
> 
> In any case having the same compatible string for two drivers is not
> correct and should be fixed. To fix this, and maintain backward
> compatibility, we can consider that the mmsys driver is the top-level
> entry point for the multimedia subsystem, so is not a pure clock
> controller but a system controller, and the drm driver is instantiated
> by that MMSYS driver.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Reviewed-by: CK Hu <ck.hu@...iatek.com>

Same here.