linux-kernel - Re: [Patch v2] mm/swap_slots.c: assign|reset cache slot by value directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c15d421-da51-dbac-336b-c65ee258a427@linux.intel.com>
Date:   Wed, 11 Mar 2020 09:10:39 -0700
From:   Tim Chen <tim.c.chen@...ux.intel.com>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v2] mm/swap_slots.c: assign|reset cache slot by value
 directly

On 3/10/20 10:53 PM, Wei Yang wrote:
> Currently we use a tmp pointer, pentry, to transfer and reset swap cache
> slot, which is a little redundant. Swap cache slot stores the entry
> value directly, assign and reset it by value would be straight forward.
> 
> Also this patch merges the else and if, since this is the only case we
> refill and repeat swap cache.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...ux.alibaba.com>
> CC: Tim Chen <tim.c.chen@...ux.intel.com>

Acked-by: Tim Chen <tim.c.chen@...ux.intel.com>

> 
> ---
> v2: keep the reset step after use, but remove the tmp pointer
> ---