linux-kernel - Re: [EXTERNAL] Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Mar 2020 11:43:00 -0500
From:   Ricardo Rivera-Matos <r-rivera-matos@...com>
To:     Dan Murphy <dmurphy@...com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Sandeep Patil <sspatil@...roid.com>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-team@...roid.com>
Subject: Re: [EXTERNAL] Re: [PATCH v4 2/4] power_supply: Add additional health
 properties to the header

Sebastian

On 3/11/20 6:29 AM, Dan Murphy wrote:
> Sebastian
>
> On 3/10/20 4:30 PM, Sebastian Reichel wrote:
>> Hi Sandeep,
>>
>> On Fri, Mar 06, 2020 at 03:55:48PM -0800, Sandeep Patil wrote:
>>> On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote:
>>>> Hi,
>>>>
>>>> On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote:
>>>>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>>>>>
>>>>> Signed-off-by: Dan Murphy <dmurphy@...com>
>>>>> ---
>>>> Looks good. But I will not merge it without a user and have comments
>>>> for the driver.
>>> Android has been looking for these properties for a while now [1].
>>> It was added[2] when we saw that the manufacturers were implementing 
>>> these
>>> properties in the driver. I didn't know the properties were absent 
>>> upstream
>>> until yesterday. Somebody pointed out in our ongoing effort to make 
>>> sure
>>> all core kernel changes that android depends on are present upstream.
>>>
>>> I think those values are also propagated in application facing APIs in
>>> Android (but I am not sure yet, let me know if that's something you 
>>> want
>>> to find out).
>>>
>>> I wanted to chime in and present you a 'user' for this if that helps.
>> With user I meant an upstream kernel driver, which exposes the
>> values. But thanks for the pointer. This should be mentioned in
>> the patch description, also the fact that the status values are
>> directly taken from JEITA spec.
>
> I mentioned the JEITA in the cover letter but I guess you would like 
> the description in the commit message as well
>
> Dan
>
>
I have added a note mentioning that the properties are taken from the 
JEITA spec in the commit message and listing the bq2515x_charger driver 
as a user. I am waiting for feedback on my other patches in the series 
before sending you v5 patches.

Ricardo