linux-kernel - Re: [PATCH for-5.7/drivers v2 1/1] null_blk: describe the usage of fault injection param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB574995F3D16CABE85CF6182E86FD0@BYAPR04MB5749.namprd04.prod.outlook.com>
Date:   Thu, 12 Mar 2020 22:19:55 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Dongli Zhang <dongli.zhang@...cle.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for-5.7/drivers v2 1/1] null_blk: describe the usage of
 fault injection param

NVMe does have the same format in host/fault_inject.c.

This description matches what we have in :-

null_setup_fault
	__null_setup_fault()
		setup_fault_attr()

looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 03/12/2020 03:01 PM, Dongli Zhang wrote:
> As null_blk is a very good start point to test block layer, this patch
> adds description and comments to 'timeout', 'requeue' and 'init_hctx' to
> explain how to use fault injection with null_blk.
>
> The nvme has similar with nvme_core.fail_request in the form of comment.
>
> Signed-off-by: Dongli Zhang<dongli.zhang@...cle.com>