linux-kernel - Re: [PATCH] net: caif: Add lockdep expression to RCU traversal primitive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200311.225545.780993448550563267.davem@davemloft.net>
Date:   Wed, 11 Mar 2020 22:55:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     frextrite@...il.com
Cc:     kuba@...nel.org, gregkh@...uxfoundation.org, tglx@...utronix.de,
        rfontana@...hat.com, allison@...utok.net, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        joel@...lfernandes.org, madhuparnabhowmik10@...il.com,
        paulmck@...nel.org, lkp@...el.com
Subject: Re: [PATCH] net: caif: Add lockdep expression to RCU traversal
 primitive

From: Amol Grover <frextrite@...il.com>
Date: Thu, 12 Mar 2020 11:04:20 +0530

> caifdevs->list is traversed using list_for_each_entry_rcu()
> outside an RCU read-side critical section but under the
> protection of rtnl_mutex. Hence, add the corresponding lockdep
> expression to silence the following false-positive warning:
> 
> [   10.868467] =============================
> [   10.869082] WARNING: suspicious RCU usage
> [   10.869817] 5.6.0-rc1-00177-g06ec0a154aae4 #1 Not tainted
> [   10.870804] -----------------------------
> [   10.871557] net/caif/caif_dev.c:115 RCU-list traversed in non-reader section!!
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Amol Grover <frextrite@...il.com>

Applied, thank you.