linux-kernel - RE: [PATCH v2 05/17] drm/arc: make arcgpu_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR1201MB0120F8E7C1AECE8E4F52BA89A1FD0@CY4PR1201MB0120.namprd12.prod.outlook.com>
Date:   Thu, 12 Mar 2020 07:55:34 +0000
From:   Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:     Wambui Karuga <wambui.karugax@...il.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0.

Hi Wambui,

> -----Original Message-----
> From: Wambui Karuga <wambui.karugax@...il.com>
> Sent: Tuesday, March 10, 2020 8:31 PM
> To: airlied@...ux.ie; daniel@...ll.ch; Alexey Brodkin <abrodkin@...opsys.com>
> Cc: dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; gregkh@...uxfoundation.org
> Subject: [PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0.
> 
> Since commit 987d65d01356 (drm: debugfs: make
> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
> fails and should return void. Therefore, remove its use as the
> return value of arcpgu_debugfs_init() and have the latter function return
> 0 directly.
> 
> v2: convert the function to return 0 instead of void to avoid breaking
> the build and ensure that this individual patch compiles properly.
> 
> References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
> Signed-off-by: Wambui Karuga <wambui.karugax@...il.com>

Thanks for the patch!

Acked-by: Alexey Brodkin <abrodkin@...opsys.com>