linux-kernel - R: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00aa01d5f850$2b6ddcb0$82499610$@gmail.com>
Date:   Thu, 12 Mar 2020 10:25:26 +0100
From:   <ansuelsmth@...il.com>
To:     "'Bjorn Andersson'" <bjorn.andersson@...aro.org>
Cc:     <agross@...nel.org>, "'Rob Herring'" <robh+dt@...nel.org>,
        "'Mark Rutland'" <mark.rutland@....com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: R: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock

> On Wed 11 Mar 06:09 PDT 2020, Ansuel Smith wrote:
> 
> > ipq806x rpm definition was missing for a long time.
> > Add this to make this soc support rpm.
> >
> 
> I merged the dt-binding patch, but please update dts to use:
> 	compatible = "qcom,scm-ipq806x", "qcom,scm";
> 
> instead of adding the platform specific compatible in the driver.
> 
> Regards,
> Bjorn
> 

Should I drop the added compatible in qcom_scm.c or just
keep it and add the definition in the ipq806x dts?

> > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> > ---
> >  drivers/firmware/qcom_scm.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qcom_scm.c
> b/drivers/firmware/qcom_scm.c
> > index 059bb0fbae9e..d13ef3cd8cf5 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -1144,6 +1144,7 @@ static const struct of_device_id
> qcom_scm_dt_match[] = {
> >
> SCM_HAS_BUS_CLK)
> >  	},
> >  	{ .compatible = "qcom,scm-ipq4019" },
> > +	{ .compatible = "qcom,scm-ipq806x" },
> >  	{ .compatible = "qcom,scm-msm8660", .data = (void *)
> SCM_HAS_CORE_CLK },
> >  	{ .compatible = "qcom,scm-msm8960", .data = (void *)
> SCM_HAS_CORE_CLK },
> >  	{ .compatible = "qcom,scm-msm8916", .data = (void
> *)(SCM_HAS_CORE_CLK |
> > --
> > 2.25.0
> >