[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fa07756217b3c033c7e5af495a03ff5655947450.camel@perches.com>
Date: Thu, 12 Mar 2020 02:37:31 -0700
From: Joe Perches <joe@...ches.com>
To: Masahiro Yamada <masahiroy@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use
fallthrough;
On Thu, 2020-03-12 at 18:02 +0900, Masahiro Yamada wrote:
> On Thu, Mar 12, 2020 at 5:56 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > On Wed, Mar 11, 2020 at 07:31:07AM -0700, Joe Perches wrote:
> > > On Wed, 2020-03-11 at 14:15 +0900, Masahiro Yamada wrote:
> > > > On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@...ches.com> wrote:
> > > > > Convert the various uses of fallthrough comments to fallthrough;
> > > > >
> > > > > Done via script
> > > > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > > > >
> > > > > Signed-off-by: Joe Perches <joe@...ches.com>
> > > >
> > > > Acked-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > > >
> > > >
> > > > But, I think the patch subject should be prefixed:
> > > > "serial: 8250_uniphier:"
> > >
> > > Yeah thanks, that's difficult to script though.
> > >
> > >
> >
> > Kernel development is hard :)
>
> It is strange to process this per-platform
> and to send out a giant series that
> consists of 491 patches.
>
> This is very trivial conversion.
>
> I think it is better to have a single patch
> to convert all files under drivers/tty/serial/,
> with the patch subject "serial:".
The difficulty there is determining where these
subsystem spanning blocks should begin and end.
That could not be done for instance with drivers/net.
As I have suggested a few times, better still
would be to have a mechanism for scripted patches
applied possibly as single treewide patch.
Likely applied only at an -rc1.
The stated negatives to a treewide mechanism
have been difficulty to backport to -stable.
Perhaps a mechanism like
git format-patch --stdout <treewide_commit_to_backport> | \
git apply --include=<specific_files>
with some automated rewrite of the treewide patch subject
then commit could help.
Powered by blists - more mailing lists