[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <OF618C17D0.837A4D16-ON48258529.0009AFE3-48258529.0009F227@mxic.com.tw>
Date: Thu, 12 Mar 2020 09:48:38 +0800
From: masonccyang@...c.com.tw
To: "Boris Brezillon" <boris.brezillon@...labora.com>
Cc: allison@...utok.net, bbrezillon@...nel.org,
frieder.schrempf@...tron.de, juliensu@...c.com.tw,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
miquel.raynal@...tlin.com, rfontana@...hat.com, richard@....at,
s.hauer@...gutronix.de, stefan@...er.ch, tglx@...utronix.de,
vigneshr@...com, yuehaibing@...wei.com
Subject: Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume
operation
Hi Boris,
> > > > > ---
> > > > > drivers/mtd/nand/raw/nand_base.c | 11 ++++++++---
> > > > > include/linux/mtd/rawnand.h | 4 ++++
> > > > > 2 files changed, 12 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c
> > b/drivers/mtd/nand/raw/nand_base.c
> > > > > index 769be81..b44e460 100644
> > > > > --- a/drivers/mtd/nand/raw/nand_base.c
> > > > > +++ b/drivers/mtd/nand/raw/nand_base.c
> > > > > @@ -4327,7 +4327,9 @@ static int nand_suspend(struct mtd_info
*mtd)
> > > > > struct nand_chip *chip = mtd_to_nand(mtd);
> > > > >
> > > > > mutex_lock(&chip->lock);
> > > > > - chip->suspended = 1;
> > > > > + if (chip->_suspend)
> > > > > + if (!chip->_suspend(chip))
> > > > > + chip->suspended = 1;
> > >
> > > Shouldn't you propagate the error to the caller if chip->_suspend()
> > > fails?
> >
> > Currently, chip->suspend() just do sending command to nand chip and
> > I think caller could check chip->suspend = 1 or 0 to know the status
> > of nand chip.
>
> No, it can't. The caller (AKA the MTD layer) has no idea about this
> chip->suspend field, actually it doesn't even know about the nand_chip
> struct. The mtd->_suspend() hook is here to abstract HW details, so
> it's the raw NAND framework responsibility to propagate the error code
> returned by chip->suspend().
Got it, thanks!
best regards,
Mason
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
Powered by blists - more mailing lists