linux-kernel - Re: [PATCH v7 13/48] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4045caf-0ad4-9642-808b-61bdcc575ac2@gmail.com>
Date:   Thu, 12 Mar 2020 18:26:05 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jiada Wang <jiada_wang@...tor.com>, jikos@...nel.org,
        benjamin.tissoires@...hat.com, rydberg@...math.org,
        dmitry.torokhov@...il.com, nick@...anahar.org, bsz@...ihalf.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        erosca@...adit-jv.com, Andrew_Gabbasov@...tor.com
Subject: Re: [PATCH v7 13/48] Input: atmel_mxt_ts - add regulator control
 support

12.02.2020 11:41, Jiada Wang пишет:
> From: Nick Dyer <nick.dyer@...ev.co.uk>
> 
> Allow the driver to optionally manage enabling/disable power to the touch
> controller itself. If the regulators are not present then use the deep
> sleep power mode instead.
> 
> For a correct power on sequence, it is required that we have control over
> the RESET line.

...
>  /* Firmware files */
>  #define MXT_FW_NAME		"maxtouch.fw"
> @@ -215,6 +217,9 @@ enum t100_type {
>  #define MXT_CRC_TIMEOUT		1000	/* msec */
>  #define MXT_FW_RESET_TIME	3000	/* msec */
>  #define MXT_FW_CHG_TIMEOUT	300	/* msec */
> +#define MXT_REGULATOR_DELAY	150	/* msec */
> +#define MXT_CHG_DELAY	        100	/* msec */
                                ^
Please use a tab instead of white-spaces. Same for MXT_COMMS_RETRIGEN in
the patch #4.