linux-kernel - Re: [PATCH v3 1/8] usb: Add MA-USB Host kernel module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a950d4e0-b9e6-ef44-9c83-35958154b36f@displaylink.com>
Date:   Thu, 12 Mar 2020 17:23:53 +0100
From:   Vladimir Stankovic <vladimir.stankovic@...playlink.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-usb <linux-usb@...r.kernel.org>,
        mausb-host-devel <mausb-host-devel@...playlink.com>
Subject: Re: [PATCH v3 1/8] usb: Add MA-USB Host kernel module

On 12.3.20. 16:20, Greg KH wrote:
> On Thu, Mar 12, 2020 at 03:42:30PM +0100, Vladimir Stankovic wrote:
>  > Added utility macros, kernel device creation and cleanup, functions for
>  > handling log formatting and a placeholder module for MA-USB Host device
>  > driver.
>  >
>  > Signed-off-by: Vladimir Stankovic <vladimir.stankovic@...playlink.com>
>  > ---
>  > MAINTAINERS | 7 +++
>  > drivers/usb/Kconfig | 2 +
>  > drivers/usb/Makefile | 2 +
>  > drivers/usb/mausb_host/Kconfig | 14 +++++
>  > drivers/usb/mausb_host/Makefile | 12 ++++
>  > drivers/usb/mausb_host/mausb_core.c | 90 +++++++++++++++++++++++++++++
>  > drivers/usb/mausb_host/utils.c | 85 +++++++++++++++++++++++++++
>  > drivers/usb/mausb_host/utils.h | 40 +++++++++++++
>  > 8 files changed, 252 insertions(+)
>  > create mode 100644 drivers/usb/mausb_host/Kconfig
>  > create mode 100644 drivers/usb/mausb_host/Makefile
>  > create mode 100644 drivers/usb/mausb_host/mausb_core.c
>  > create mode 100644 drivers/usb/mausb_host/utils.c
>  > create mode 100644 drivers/usb/mausb_host/utils.h
>  >
>  > diff --git a/MAINTAINERS b/MAINTAINERS
>  > index 235ab38ed478..12aac44196d7 100644
>  > --- a/MAINTAINERS
>  > +++ b/MAINTAINERS
>  > @@ -10226,6 +10226,13 @@ W: https://linuxtv.org 
> <https://linuxtv.org>
>  > S: Maintained
>  > F: drivers/media/radio/radio-maxiradio*
>  > +MA USB HOST DRIVER
>  > +M: Vladimir Stankovic <vladimir.stankovic@...playlink.com>
>  > +L: mausb-host-devel@...playlink.com
>  > +W: https://www.displaylink.com 
> <https://www.displaylink.com>
>  > +S: Maintained
>  > +F: drivers/usb/mausb_host/*
>  > +
>  > MCAN MMIO DEVICE DRIVER
>  > M: Dan Murphy <dmurphy@...com>
>  > M: Sriram Dash <sriram.dash@...sung.com>
> 
> Does that patch look correct?
> 
> Does this apply?
> 
> Something is odd here :(
> 
> 
>  > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>  > index 275568abc670..4e92f1fa0fa5 100644
>  > --- a/drivers/usb/Kconfig
>  > +++ b/drivers/usb/Kconfig
>  > @@ -164,6 +164,8 @@ source "drivers/usb/misc/Kconfig"
>  > source "drivers/usb/atm/Kconfig"
>  > +source "drivers/usb/mausb_host/Kconfig"
>  > +
>  > endif # USB
>  > source "drivers/usb/phy/Kconfig"
> 
> Yeah, something is really wrong with your email client :(
> 
> Can you use 'git send-email' to send all of these out so they do not get
> corrupted?
> 
> That will also fix the lack of email threading which this series still
> has as well.
> 
> thanks,
> 
> greg k-h
I'd say it's the issue with mail server used by company, since patches 
and mails were generated via git (i.e. used git imap-send to create mail 
drafts). One of the reasons we've sent attachments in the first version 
of the patch was to avoid weird mail client/server issues.

Anyhow, I've tried applying diffs from linux-usb mailthread and from 
patchwork, and that failed as expected, stating that patch is corrupt. 
However, comparison of those diffs with the .patch file generated with 
git, provided somewhat odd result: only first 30+ lines of the diff 
(mail headers excluded) contained additional space chars that are not 
part of the git-generated .patch files (specifically, a single space 
char is added at the start of each line that is not being modified by 
the patch itself; only Kconfig, Makefile, and MAINTAINERS are affected); 
the rest of the diff (new source code) matched with .patch file.

Been expecting "tabs vs spaces" issue that is specific to mail 
clients/servers, but this makes it a bit odd.

Will check if this issue (prepended single space chars) is already 
reported/fixed within the community.

Regards,
Vladimir.