linux-kernel - Re: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7541667-05e1-6a54-165f-7d8ad66f5b33@linaro.org>
Date:   Thu, 12 Mar 2020 19:23:41 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     afzal mohammed <afzal.mohd.ma@...il.com>
Cc:     allison@...utok.net, baohua@...nel.org,
        bcm-kernel-feedback-list@...adcom.com, f.fainelli@...il.com,
        festevam@...il.com, gregkh@...uxfoundation.org, info@...ux.net,
        kernel@...gutronix.de, kgene@...nel.org, khilman@...libre.com,
        krzk@...nel.org, kstewart@...uxfoundation.org,
        linus.walleij@...aro.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux@...sktech.co.nz, nsaenzjulienne@...e.de, rjui@...adcom.com,
        s.hauer@...gutronix.de, sbranden@...adcom.com, shawnguo@...nel.org,
        tglx@...utronix.de, u.kleine-koenig@...gutronix.de
Subject: Re: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with
 non-NULL dev_id

On 12/03/2020 07:48, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> request_irq() does a few sanity checks that were not done in
> setup_irq(), if they fail irq registration will fail. One of the check
> is to ensure that non-NULL dev_id is passed in the case of shared irq.
> 
> Fix it by passing non-NULL dev_id while registering the shared irq.
> 
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Signed-off-by: afzal mohammed <afzal.mohd.ma@...il.com>
> ---
> 
> Hi Daniel,
> 
> i have assumed that you would not rebase your drivers/next tree & put the
> SHA-id in Fixes tag.

Applied, thanks


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog