linux-kernel - Re: [PATCH] sfc: ethtool: Refactor to remove fallthrough comments in case blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200312.113002.2094797356741004781.davem@davemloft.net>
Date:   Thu, 12 Mar 2020 11:30:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     linux-net-drivers@...arflare.com, ecree@...arflare.com,
        mhabets@...arflare.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sfc: ethtool: Refactor to remove fallthrough comments
 in case blocks

From: Joe Perches <joe@...ches.com>
Date: Tue, 10 Mar 2020 19:41:41 -0700

> Converting fallthrough comments to fallthrough; creates warnings
> in this code when compiled with gcc.
> 
> This code is overly complicated and reads rather better with a
> little refactoring and no fallthrough uses at all.
> 
> Remove the fallthrough comments and simplify the written source
> code while reducing the object code size.
> 
> Consolidate duplicated switch/case blocks for IPV4 and IPV6.
> 
> defconfig x86-64 with sfc:
> 
> $ size drivers/net/ethernet/sfc/ethtool.o*
>    text	   data	    bss	    dec	    hex	filename
>   10055	     12	      0	  10067	   2753	drivers/net/ethernet/sfc/ethtool.o.new
>   10135	     12	      0	  10147	   27a3	drivers/net/ethernet/sfc/ethtool.o.old
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied to net-next.