[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200313130438.73d9a56c@kicinski-fedora-PC1C0HJN>
Date: Fri, 13 Mar 2020 13:04:38 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Grygorii Strashko <grygorii.strashko@...com>
Cc: Rob Herring <robh+dt@...nel.org>, Tero Kristo <t-kristo@...com>,
"David S . Miller" <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>, Roger Quadros <rogerq@...com>,
<devicetree@...r.kernel.org>,
Murali Karicheri <m-karicheri2@...com>,
Sekhar Nori <nsekhar@...com>,
Peter Ujfalusi <peter.ujfalusi@...com>,
Kishon Vijay Abraham I <kishon@...com>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v3 05/10] net: ethernet: ti: introduce
am65x/j721e gigabit eth subsystem driver
On Fri, 13 Mar 2020 19:55:06 +0200 Grygorii Strashko wrote:
> +static void am65_cpsw_nuss_free_tx_chns(void *data)
> +{
> + struct am65_cpsw_common *common = data;
> + int i;
> +
> + for (i = 0; i < common->tx_ch_num; i++) {
> + struct am65_cpsw_tx_chn *tx_chn = &common->tx_chns[i];
nit: stray tab?
> +
> + if (!IS_ERR_OR_NULL(tx_chn->tx_chn))
> + k3_udma_glue_release_tx_chn(tx_chn->tx_chn);
> +
> + if (!IS_ERR_OR_NULL(tx_chn->desc_pool))
> + k3_udma_desc_pool_destroy(tx_chn->desc_pool);
> +
> + memset(tx_chn, 0, sizeof(*tx_chn));
> + };
nit: you also got some stray semicolons in a few places
Thanks for the changes, looks better. Hopefully someone who knows
the HW better can have a look as well.
Powered by blists - more mailing lists