linux-kernel - Re: [PATCH] arm: mach-dove: Mark dove_io_desc as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mu8kx9v3.fsf@FE-laptop>
Date:   Fri, 13 Mar 2020 21:45:04 +0100
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Vincenzo Frascino <vincenzo.frascino@....com>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH] arm: mach-dove: Mark dove_io_desc as __maybe_unused

Vincenzo Frascino <vincenzo.frascino@....com> writes:

> Without this, we get the warnings below when CONFIG_MMU is disabled:
>
> linux/arch/arm/mach-dove/common.c:51:24: warning: ‘dove_io_desc’ defined
> but not used [-Wunused-variable]
> static struct map_desc dove_io_desc[] __initdata = {
>                        ^~~~~~~~~~~~
>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Gregory Clement <gregory.clement@...tlin.com>
> Cc: Russell King <linux@...linux.org.uk>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>

Applied on mvebu/arm

Thanks,

Gregory
> ---
>  arch/arm/mach-dove/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
> index 01b830afcea9..dbe970e37895 100644
> --- a/arch/arm/mach-dove/common.c
> +++ b/arch/arm/mach-dove/common.c
> @@ -48,7 +48,7 @@
>  /*****************************************************************************
>   * I/O Address Mapping
>   ****************************************************************************/
> -static struct map_desc dove_io_desc[] __initdata = {
> +static struct map_desc __maybe_unused dove_io_desc[] __initdata = {
>  	{
>  		.virtual	= (unsigned long) DOVE_SB_REGS_VIRT_BASE,
>  		.pfn		= __phys_to_pfn(DOVE_SB_REGS_PHYS_BASE),
> -- 
> 2.25.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com