linux-kernel - Re: [PATCH] i2c: mv64xxx: Implement I2C_M_RECV_LEN and I2C_FUNC_SMBUS_READ_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D320E497-D240-4821-99F7-D0BE8744D3EF@studiofuga.com>
Date:   Fri, 13 Mar 2020 21:58:03 +0100
From:   Federico Fuga <fuga@...diofuga.com>
To:     Gregory CLEMENT <gregory.clement@...tlin.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: mv64xxx: Implement I2C_M_RECV_LEN and
 I2C_FUNC_SMBUS_READ_BLOCK_DATA

Hello all,



> Il giorno 13 mar 2020, alle ore 21:48, Gregory CLEMENT <gregory.clement@...tlin.com> ha scritto:
> 
> Hello Wolfram,
> 
>> On Sat, Jan 18, 2020 at 12:58:20PM +0100, Federico Fuga wrote:
>>> The i2c_mv64xxx driver doesn't implement the I2C_M_REC_LEN function
>>> essential to allow blocks with variable length to be read from an i2c
>>> slave.
>>> This is needed to implement the SMBus Read Block Data function.
>>> 
>>> This patch implements the function by changing the bytes_left and
>>> msg len on the fly if the flag is specified.
>>> 
>>> It has been successfully tested on Allwinner A33 with a special
>>> i2c chip that returns variable length blocks on reading.
>>> 
>>> Signed-off-by: Federico Fuga <fuga@...diofuga.com>
>>> ---
>> 
>> Gregory, any comment? I can't say much about the implementation. In
>> general, this is a nice feature to have...
> 
> I thought I was already sent a reviewed by, as I reviewed this patch
> before Frederico actually sent it.
> 
> So you can even add a
> 
> Acked-by: Gregory CLEMENT <gregory.clement@...tlin.com>
> 
> Thanks,


For what it worth, I can confirm that after many weeks of use the patch works as expected without any issue.


Federico