linux-kernel - Re: [PATCH V5 2/3] dt-bindings: geni-se: Add interconnect binding for GENI QUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313220638.GA30287@bogus>
Date:   Fri, 13 Mar 2020 17:06:38 -0500
From:   Rob Herring <robh@...nel.org>
To:     Akash Asthana <akashast@...eaurora.org>
Cc:     agross@...nel.org, mark.rutland@....com,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mgautam@...eaurora.org,
        rojay@...eaurora.org, c_skakit@...eaurora.org, mka@...omium.org
Subject: Re: [PATCH V5 2/3] dt-bindings: geni-se: Add interconnect binding
 for GENI QUP

On Fri, Mar 13, 2020 at 03:59:09PM +0530, Akash Asthana wrote:
> Add documentation for the interconnect and interconnect-names properties
> for the GENI QUP.
> 
> Signed-off-by: Akash Asthana <akashast@...eaurora.org>
> ---
> Changes in V5:
>  - Add interconnect property for QUP wrapper (parent node).
>  - Add minItems = 2 for interconnect property in child nodes
> 
>  .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml       | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> index 23282ab..533400b 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -46,6 +46,12 @@ properties:
>  
>    ranges: true
>  
> +  interconnects:
> +    maxItems: 1
> +
> +  interconnect-names:
> +    const: qup-core
> +
>  required:
>    - compatible
>    - reg
> @@ -73,6 +79,16 @@ patternProperties:
>          description: Serial engine core clock needed by the device.
>          maxItems: 1
>  
> +      interconnects:
> +         minItems: 2
> +         maxItems: 3
> +
> +      interconnect-names:
> +         items:
> +           - const: qup-core
> +           - const: qup-config
> +           - const: qup-memory

Don't you need 'minItems: 2' here?

Rob