linux-kernel - Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Mar 2020 12:57:50 +0530
From:   Shreeya Patel <shreeya.patel23498@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Joe Perches <joe@...ches.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        sbrivio@...hat.com, daniel.baluta@...il.com,
        nramas@...ux.microsoft.com, hverkuil@...all.nl,
        Larry.Finger@...inger.net
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit:
 Remove unnecessary conditions

On Fri, 2020-03-13 at 10:20 +0300, Dan Carpenter wrote:
> On Wed, Mar 11, 2020 at 07:08:11PM +0530, Shreeya Patel wrote:
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > index e813382e78a6..643592b0bd38 100644
> > --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> > @@ -551,18 +551,11 @@ static void HalRxAggr8723BSdio(struct adapter
> > *padapter)
> >  
> >  	pregistrypriv = &padapter->registrypriv;
> >  
> > -	if (pregistrypriv->wifi_spec) {
> > -		/*  2010.04.27 hpfan */
> > -		/*  Adjust RxAggrTimeout to close to zero disable
> > RxAggr, suggested by designer */
> > -		/*  Timeout value is calculated by 34 / (2^n) */
> > -		valueDMATimeout = 0x06;
> > -		valueDMAPageCount = 0x06;
> > -	} else {
> > -		/*  20130530, Isaac@SD1 suggest 3 kinds of parameter */
> > -		/*  TX/RX Balance */
> > -		valueDMATimeout = 0x06;
> > -		valueDMAPageCount = 0x06;
> > -	}
> > +	/*  2010.04.27 hpfan */
> 
> Delete these sorts of comments where it's just a name of someone and
> a time stamp when they wrote it.  We don't know how to contact
> "hpfan"
> so it's useless.
> 

Thanks Joe and Dan for your explanation. I will remove the comments and
send the patch again.

> regards,
> dan carpenter
> 
>