linux-kernel - Re: [PATCH] thermal: imx: Calling imx_thermal_unregister_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Mar 2020 13:31:55 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Anson Huang <Anson.Huang@....com>, rui.zhang@...el.com,
        amit.kucheria@...durent.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     Linux-imx@....com
Subject: Re: [PATCH] thermal: imx: Calling
 imx_thermal_unregister_legacy_cooling() in .remove

On 13/03/2020 09:28, Anson Huang wrote:
> imx_thermal_unregister_legacy_cooling() should be used for handling
> legacy cpufreq cooling cleanups in .remove callback instead of
> calling cpufreq_cooling_unregister() and cpufreq_cpu_put() directly,
> especially for !CONFIG_CPU_FREQ scenario, no operation needed for
> handling legacy cpufreq cooling cleanups at all.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>

Applied, thanks

> ---
>  drivers/thermal/imx_thermal.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index d2fa301..e761c9b 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -865,8 +865,7 @@ static int imx_thermal_remove(struct platform_device *pdev)
>  		clk_disable_unprepare(data->thermal_clk);
>  
>  	thermal_zone_device_unregister(data->tz);
> -	cpufreq_cooling_unregister(data->cdev);
> -	cpufreq_cpu_put(data->policy);
> +	imx_thermal_unregister_legacy_cooling(data);
>  
>  	return 0;
>  }
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog