linux-kernel - Re: [RESEND PATCH v2 8/9] ASoC: qcom: q6asm-dai: add support for ALAC and APE decoders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200313124049.GJ4885@vkoul-mobl>
Date:   Fri, 13 Mar 2020 18:10:49 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Patrick Lai <plai@...eaurora.org>,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 8/9] ASoC: qcom: q6asm-dai: add support for
 ALAC and APE decoders

On 13-03-20, 12:15, Srinivas Kandagatla wrote:
> 
> 
> On 13/03/2020 10:16, Vinod Koul wrote:
> > Qualcomm DSPs also supports the ALAC and APE decoders, so add support
> > for these and convert the snd_codec_params to qdsp format.
> > 
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> One minor nit, other that,
> 
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

Thanks Srini for the reviews

> > ---
> >   sound/soc/qcom/qdsp6/q6asm-dai.c | 67 +++++++++++++++++++++++++++++++-
> >   1 file changed, 66 insertions(+), 1 deletion(-)
> > 
> > diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
> > index 53c250778eea..948710759824 100644
> > --- a/sound/soc/qcom/qdsp6/q6asm-dai.c
> > +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
> > @@ -628,12 +628,16 @@ static int q6asm_dai_compr_set_params(struct snd_compr_stream *stream,
> >   	struct q6asm_dai_data *pdata;
> >   	struct q6asm_flac_cfg flac_cfg;
> >   	struct q6asm_wma_cfg wma_cfg;
> > +	struct q6asm_alac_cfg alac_cfg;
> > +	struct q6asm_ape_cfg ape_cfg;
> >   	unsigned int wma_v9 = 0;
> >   	struct device *dev = c->dev;
> >   	int ret;
> >   	union snd_codec_options *codec_options;
> >   	struct snd_dec_flac *flac;
> >   	struct snd_dec_wma *wma;
> > +	struct snd_dec_alac *alac;
> > +	struct snd_dec_ape *ape;
> >   	codec_options = &(prtd->codec_param.codec.options);
> > @@ -756,6 +760,65 @@ static int q6asm_dai_compr_set_params(struct snd_compr_stream *stream,
> >   			dev_err(dev, "WMA9 CMD failed:%d\n", ret);
> >   			return -EIO;
> >   		}
> > +		break;
> > +
> > +	case SND_AUDIOCODEC_ALAC:
> > +		memset(&alac_cfg, 0x0, sizeof(alac_cfg));
> > +		alac = &codec_options->alac_d;
> > +
> > +		alac_cfg.sample_rate = params->codec.sample_rate;
> > +		alac_cfg.avg_bit_rate = params->codec.bit_rate;
> > +		alac_cfg.bit_depth = prtd->bits_per_sample;
> > +		alac_cfg.num_channels = params->codec.ch_in;
> > +
> > +		alac_cfg.frame_length = alac->frame_length;
> > +		alac_cfg.pb = alac->pb;
> > +		alac_cfg.mb = alac->mb;
> > +		alac_cfg.kb = alac->kb;
> > +		alac_cfg.max_run = alac->max_run;
> > +		alac_cfg.compatible_version = alac->compatible_version;
> > +		alac_cfg.max_frame_bytes = alac->max_frame_bytes;
> > +
> > +		switch (params->codec.ch_in) {
> > +		case 1:
> > +			alac_cfg.channel_layout_tag = (100 << 16) | 1;
> 
> We should probably define this layout tag in asm.h
> something like:
> 
> #define ALAC_CHANNEL_LAYOUT_TAG_Mono (100<<16) | 1
> #define ALAC_CHANNEL_LAYOUT_TAG_STEREO (100<<16) | 2

Sure I will add these

-- 
~Vinod