linux-kernel - Re: [PATCH 2/3] binderfs: add stress test for binderfs binder devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313125404.fnsktenn5crufkxr@wittgenstein>
Date:   Fri, 13 Mar 2020 13:54:04 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Todd Kjos <tkjos@...roid.com>, ard.biesheuvel@...aro.org,
        ardb@...nel.org, john.stultz@...aro.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        naresh.kamboju@...aro.org, shuah@...nel.org,
        Arve Hjønnevåg <arve@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>, hridya@...gle.com,
        kernel-team@...roid.com
Subject: Re: [PATCH 2/3] binderfs: add stress test for binderfs binder devices

On Thu, Mar 12, 2020 at 04:53:17PM -0700, Kees Cook wrote:
> On Thu, Mar 12, 2020 at 02:15:30PM +0100, Christian Brauner wrote:
> > This adds a stress test that should hopefully help us catch regressions
> > for [1], [2], and [3].
> > 
> > [1]: 2669b8b0c798 ("binder: prevent UAF for binderfs devices")
> > [2]: f0fe2c0f050d ("binder: prevent UAF for binderfs devices II")
> > [3]: 211b64e4b5b6 ("binderfs: use refcount for binder control devices too")
> > Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> 
> Do you care about 80-char line limits? (Or does the selftest tree? There
> are a few in here...)

They should mostly all be calls to kselftest print functions. I usually
never wrap them in tests so it's easy to do:

git grep "Find me this error string"

which becames annoying when you wrap them. :)